Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-12-04 Thread Eric Engestrom
On Tuesday, 2018-12-04 15:36:28 +0200, andrey simiklit wrote: > Hello, > > I'm sorry for disturbing, could I ask you to push this patch if it > possible? ))) Sorry yes, thanks for the reminder :) I just pushed it! > > Regards, > Andrii. > > On Fri, Nov 30, 2018 at 6:19 PM andrey simiklit > wr

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-12-04 Thread andrey simiklit
Hello, I'm sorry for disturbing, could I ask you to push this patch if it possible? ))) Regards, Andrii. On Fri, Nov 30, 2018 at 6:19 PM andrey simiklit wrote: > On Fri, Nov 30, 2018 at 5:49 PM Eric Engestrom > wrote: > >> On Friday, 2018-11-30 15:47:11 +, Lionel Landwerlin wrote: >> > On

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-30 Thread andrey simiklit
On Fri, Nov 30, 2018 at 5:49 PM Eric Engestrom wrote: > On Friday, 2018-11-30 15:47:11 +, Lionel Landwerlin wrote: > > On 14/11/2018 16:30, asimiklit.w...@gmail.com wrote: > > > From: Andrii Simiklit > > > > > > 1. tools/i965_disasm.c:58:4: warning: > > > ignoring return value of ‘frea

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-30 Thread Eric Engestrom
On Friday, 2018-11-30 15:47:11 +, Lionel Landwerlin wrote: > On 14/11/2018 16:30, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > 1. tools/i965_disasm.c:58:4: warning: > > ignoring return value of ‘fread’, > > declared with attribute warn_unused_result > >

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-30 Thread Lionel Landwerlin
On 14/11/2018 16:30, asimiklit.w...@gmail.com wrote: From: Andrii Simiklit 1. tools/i965_disasm.c:58:4: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result fread(assembly, *end, 1, fp); v2: Fixed incorrect return value check. ( Eric E

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-30 Thread andrey simiklit
Hello, Could you please take a look on this v4 if it is possible? Thanks, Andrii. On Wed, Nov 14, 2018 at 6:30 PM wrote: > From: Andrii Simiklit > > 1. tools/i965_disasm.c:58:4: warning: > ignoring return value of ‘fread’, > declared with attribute warn_unused_result > fread(as

[Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-14 Thread asimiklit . work
From: Andrii Simiklit 1. tools/i965_disasm.c:58:4: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result fread(assembly, *end, 1, fp); v2: Fixed incorrect return value check. ( Eric Engestrom ) v3: Zero size file check placed before fread w