On Fri, 2019-09-06 at 07:40 -0400, Alyssa Rosenzweig wrote:
> I think we can simplify `panfrost_flush_draw_deps`. We need to flush
> any BOs that write where we read/write and any BOs that read where we
> write. Since we collect this information via add_bo, we can
> implement this logic generically
> I'm definitely biased :-), but I do find the changes at hand not that
> invasive: most of the logic is placed in helpers that are called in one
> or 2 places. I mean, removing those explicit flushes when the time
> comes shouldn't be too hard, and I do think it's one step in the right
> direction
On Fri, 6 Sep 2019 08:10:55 -0400
Alyssa Rosenzweig wrote:
> > Now, if we go for the dep graph solution, that's probably a non issue,
> > since deps can be added at any point as long as they are described
> > before the flush happens.
> >
> > [snip]
> >
> > Thanks for the detailed explanation. I'
> Now, if we go for the dep graph solution, that's probably a non issue,
> since deps can be added at any point as long as they are described
> before the flush happens.
>
> [snip]
>
> Thanks for the detailed explanation. I'll look into that. This being
> said, I was wondering if we shouldn't merge
On Fri, 6 Sep 2019 07:40:17 -0400
Alyssa Rosenzweig wrote:
> I think we can simplify `panfrost_flush_draw_deps`. We need to flush
> any BOs that write where we read/write and any BOs that read where we
> write. Since we collect this information via add_bo, we can
> implement this logic genericall
I think we can simplify `panfrost_flush_draw_deps`. We need to flush
any BOs that write where we read/write and any BOs that read where we
write. Since we collect this information via add_bo, we can
implement this logic generically, without requiring a special case
for every kind of BO we might nee
We adjust the code to explicitly request flush of batches accessing
BOs they care about. Thanks to that, we can get rid of the implicit
serialization done in panfrost_batch_submit() and
panfrost_set_framebuffer_state(). Finally, panfrost_flush() is
changed to to flush all pending batches.
Signed-o
