Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Jason Ekstrand
On Fri, Apr 7, 2017 at 5:01 PM, Nanley Chery wrote: > On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > > We tend to try to reduce the number of allocation calls the Vulkan > > driver uses by doing a single allocation whenever possible for a data > > structure. While this has cer

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Nanley Chery
On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > We tend to try to reduce the number of allocation calls the Vulkan > driver uses by doing a single allocation whenever possible for a data > structure. While this has certain downsides (usually code complexity), > it does mean error

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 04:30:49PM -0700, Jason Ekstrand wrote: >On Fri, Apr 7, 2017 at 3:19 PM, Chris Wilson <[1]ch...@chris-wilson.co.uk> >wrote: > > On Fri, Apr 07, 2017 at 02:41:13PM -0700, Jason Ekstrand wrote: > >    On Fri, Apr 7, 2017 at 1:26 PM, Chris Wilson > <[1][

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Jason Ekstrand
On Fri, Apr 7, 2017 at 3:19 PM, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 02:41:13PM -0700, Jason Ekstrand wrote: > >On Fri, Apr 7, 2017 at 1:26 PM, Chris Wilson <[1] > ch...@chris-wilson.co.uk> > >wrote: > > > > On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > >

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 02:41:13PM -0700, Jason Ekstrand wrote: >On Fri, Apr 7, 2017 at 1:26 PM, Chris Wilson <[1]ch...@chris-wilson.co.uk> >wrote: > > On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > > +#define _ANV_MULTIALLOC_UPDATE_POINTER(_i) \ > > +   i

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Jason Ekstrand
On Fri, Apr 7, 2017 at 1:26 PM, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > > We tend to try to reduce the number of allocation calls the Vulkan > > driver uses by doing a single allocation whenever possible for a data > > structure. While this has cer

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > We tend to try to reduce the number of allocation calls the Vulkan > driver uses by doing a single allocation whenever possible for a data > structure. While this has certain downsides (usually code complexity), > it does mean error

[Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

2017-04-07 Thread Jason Ekstrand
We tend to try to reduce the number of allocation calls the Vulkan driver uses by doing a single allocation whenever possible for a data structure. While this has certain downsides (usually code complexity), it does mean error handling and cleanup is much easier. This commit adds a nice little he