Re: [Mesa-dev] [PATCH v3 1/2] isl: don't crash when creating a huge image

2018-01-16 Thread Samuel Iglesias Gonsálvez
On 16/01/18 17:10, Jason Ekstrand wrote: > I'm a bit unclear here.  Was ISL crashing before or was it returning > false and anv crashing?  If it was anv crashing due to an assert(ok), > then maybe it's best to just make anv fail gracefully with > VK_ERROR_OUT_OF_DEVICE_MEMORY.  Setting size to UINT

Re: [Mesa-dev] [PATCH v3 1/2] isl: don't crash when creating a huge image

2018-01-16 Thread Jason Ekstrand
I'm a bit unclear here. Was ISL crashing before or was it returning false and anv crashing? If it was anv crashing due to an assert(ok), then maybe it's best to just make anv fail gracefully with VK_ERROR_OUT_OF_DEVICE_MEMORY. Setting size to UINT64_MAX seems really ugly to me. On Mon, Jan 15,

[Mesa-dev] [PATCH v3 1/2] isl: don't crash when creating a huge image

2018-01-15 Thread Samuel Iglesias Gonsálvez
The HW has some limits but, according to the spec, we can create the image as it has not yet any memory backing it. This patch logs a debug error and set the size to the UINT64_MAX in order to avoid allocating actual memory later. Fixes the crashes on BDW for the following tests: dEQP-VK.pipeline