Re: [Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-22 Thread Dylan Baker
Thanks! I was going to push these today if someone didn't give me an r-b, but I wanted to give people proper time. Dylan Quoting Mathieu Bridon (2018-08-22 07:35:39) > I just learned I was supposed to send this :) > > Reviewed-by: Mathieu Bridon > > On Fri, 2018-08-17 at 11:07 -0700, Dylan Bak

Re: [Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-22 Thread Mathieu Bridon
I just learned I was supposed to send this :) Reviewed-by: Mathieu Bridon On Fri, 2018-08-17 at 11:07 -0700, Dylan Baker wrote: > v2: - explicitly decode the output of subprocesses > - handle bytes and string types consistently rather than relying > on > python 2's coercion for bytes a

[Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
v2: - explicitly decode the output of subprocesses - handle bytes and string types consistently rather than relying on python 2's coercion for bytes and ignoring them in python 3 v3: - explicitly set encode as well as decode - python 2.7 and 3.x `bytes` instead of defining an alias --