Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-10 Thread Rob Clark
On Tue, Apr 10, 2018 at 1:50 PM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 1:17 PM, Jason Ekstrand wrote: >> On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: >>> >>> On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand >>> wrote: >>> > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >>> >> >>>

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-10 Thread Rob Clark
On Tue, Apr 10, 2018 at 1:17 PM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: >> >> On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand >> wrote: >> > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >> >> >> >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand >> >>

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-10 Thread Jason Ekstrand
On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: > >> > >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand > >> wrote: > >> > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark > wrote:

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-10 Thread Rob Clark
On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >> >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand >> wrote: >> > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: >> >> >> >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand >> >>

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-10 Thread Jason Ekstrand
On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: > >> > >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand > >> wrote: > >> > + A bunch of potentially interested parties. > >> > >

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-10 Thread Rob Clark
On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: >> >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand >> wrote: >> > + A bunch of potentially interested parties. >> > >> > On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho >

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-10 Thread Jason Ekstrand
On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: > On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand > wrote: > > + A bunch of potentially interested parties. > > > > On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho > > wrote: > >> > >> Hi, > >> > >> > typedef struct { > >> > -

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-10 Thread Rob Clark
On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand wrote: > + A bunch of potentially interested parties. > > On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho > wrote: >> >> Hi, >> >> > typedef struct { >> > - nir_parameter_type param_type; >> > - const struct glsl_type *type; >> >

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-09 Thread Jason Ekstrand
+ A bunch of potentially interested parties. On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Hi, > > > typedef struct { > > - nir_parameter_type param_type; > > - const struct glsl_type *type; > > + uint8_t num_components; > > + uint8_t

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-09 Thread Caio Marcelo de Oliveira Filho
Hi, > typedef struct { > - nir_parameter_type param_type; > - const struct glsl_type *type; > + uint8_t num_components; > + uint8_t bit_size; > } nir_parameter; (...) > @@ -683,18 +692,12 @@ validate_tex_instr(nir_tex_instr *instr, validate_state > *state) > static void > validate_c

[Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

2018-04-03 Thread Jason Ekstrand
This commit completely reworks function calls in NIR. Instead of having a set of variables for the parameters and return value, nir_call_instr now has simply has a number of sources which get mapped to load_param intrinsics inside the functions. It's up to the client API to build an ABI on top of