Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-25 Thread Danylo Piliaiev
Hi Emil, On 24.07.18 19:23, Emil Velikov wrote: Hi Danylo, Having a closer look inspired by Eric's comments On 24 July 2018 at 15:37, Danylo Piliaiev wrote: Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. As you bump the libdrm version: - drop the existing DRM_EVENT_CO

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-25 Thread Danylo Piliaiev
Hi Eric, On 24.07.18 18:43, Eric Engestrom wrote: On Friday, 2018-07-13 16:57:34 +0300, Danylo Piliaiev wrote: Make xlease automatically enabled only if xcb-randr >= 1.13, check its version if manually enabled. Enable VK_EXT_display_control only when libdrm >= 2.4.89 Check for DRM_EVENT_CONT

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-24 Thread Emil Velikov
Hi Danylo, Having a closer look inspired by Eric's comments On 24 July 2018 at 15:37, Danylo Piliaiev wrote: >>> Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. >>> As you bump the libdrm version: - drop the existing DRM_EVENT_CONTEXT_VERSION guard - swap the DRM_EVENT_CONTEX

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-24 Thread Eric Engestrom
On Friday, 2018-07-13 16:57:34 +0300, Danylo Piliaiev wrote: > Make xlease automatically enabled only if xcb-randr >= 1.13, > check its version if manually enabled. > > Enable VK_EXT_display_control only when libdrm >= 2.4.89 > > Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler.

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-24 Thread Danylo Piliaiev
Hi Emil, On 24.07.18 17:10, Emil Velikov wrote: Hi Danylo, On 13 July 2018 at 14:57, Danylo Piliaiev wrote: Make xlease automatically enabled only if xcb-randr >= 1.13, check its version if manually enabled. Enable VK_EXT_display_control only when libdrm >= 2.4.89 Check for DRM_EVENT_CONTEX

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-24 Thread Emil Velikov
Hi Danylo, On 13 July 2018 at 14:57, Danylo Piliaiev wrote: > Make xlease automatically enabled only if xcb-randr >= 1.13, > check its version if manually enabled. > > Enable VK_EXT_display_control only when libdrm >= 2.4.89 > > Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. >

[Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-13 Thread Danylo Piliaiev
Make xlease automatically enabled only if xcb-randr >= 1.13, check its version if manually enabled. Enable VK_EXT_display_control only when libdrm >= 2.4.89 Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107170 h