Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-29 Thread Erik Faye-Lund
On Thu, Jun 28, 2018 at 7:49 PM Gert Wollny wrote: > > Am Donnerstag, den 28.06.2018, 18:09 +0200 schrieb Erik Faye-Lund: > > It still seems kinda strange (and fragile) to me to try to enumerate > > all possible sample locations up-front instead of querying a given > > texture for it's sample-loca

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Gert Wollny
Am Donnerstag, den 28.06.2018, 18:09 +0200 schrieb Erik Faye-Lund: > It still seems kinda strange (and fragile) to me to try to enumerate > all possible sample locations up-front instead of querying a given > texture for it's sample-locations. With virgl, querying a texture for host-side informatio

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Erik Faye-Lund
On Thu, Jun 28, 2018 at 5:54 PM Gert Wollny wrote: > > Am Donnerstag, den 28.06.2018, 17:40 +0200 schrieb Erik Faye-Lund: > > On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny > m> wrote: > > > > > > There are two aspects: > > > > > > For each number of samples there is indeed a fixes set of sample > >

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Gert Wollny
Am Donnerstag, den 28.06.2018, 17:40 +0200 schrieb Erik Faye-Lund: > On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny m> wrote: > > > > There are two aspects: > > > > For each number of samples there is indeed a fixes set of sample > > positions that only depends on the hardware. The set correspondin

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Erik Faye-Lund
On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny wrote: > > Am Donnerstag, den 28.06.2018, 17:09 +0200 schrieb Erik Faye-Lund: > > Unless I'm misunderstanding, this seems to indicate that the hardware > > has a fixed set of sample positions, which I don't think is true for > > most hardware. Instead, t

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Gert Wollny
Am Donnerstag, den 28.06.2018, 17:09 +0200 schrieb Erik Faye-Lund: > Unless I'm misunderstanding, this seems to indicate that the hardware > has a fixed set of sample positions, which I don't think is true for > most hardware. Instead, the sample locations is a function of the > multisampling mode

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Erik Faye-Lund
Unless I'm misunderstanding, this seems to indicate that the hardware has a fixed set of sample positions, which I don't think is true for most hardware. Instead, the sample locations is a function of the multisampling mode for a given surface... On Thu, Jun 28, 2018 at 3:45 PM Gert Wollny wrote:

[Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

2018-06-28 Thread Gert Wollny
Use caps to obtain the multisample sample positions for up to 16 positions and implement the according Gallium interface. Fixes (when run on GL host): dEQP-GLES31.functional.texture.multisample.samples_1.sample_position dEQP-GLES31.functional.texture.multisample.samples_2.sample_position