Re: [Mesa-dev] [PATCH v3] nir/algebraic: Rewrite bit-size inference

2018-12-05 Thread Dylan Baker
For the python bits: Reviewed-by: Dylan Baker Quoting Connor Abbott (2018-12-05 04:20:30) > Before this commit, there were two copies of the algorithm: one in C, > that we would use to figure out what bit-size to give the replacement > expression, and one in Python, that emulated the C one and tr

Re: [Mesa-dev] [PATCH v3] nir/algebraic: Rewrite bit-size inference

2018-12-05 Thread Jason Ekstrand
Rb me. Now you can review my comparison patches. 😁 On December 5, 2018 06:20:49 Connor Abbott wrote: Before this commit, there were two copies of the algorithm: one in C, that we would use to figure out what bit-size to give the replacement expression, and one in Python, that emulated the C o

[Mesa-dev] [PATCH v3] nir/algebraic: Rewrite bit-size inference

2018-12-05 Thread Connor Abbott
Before this commit, there were two copies of the algorithm: one in C, that we would use to figure out what bit-size to give the replacement expression, and one in Python, that emulated the C one and tried to prove that the C algorithm would never fail to correctly assign bit-sizes. That seemed pret