Re: [Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-13 Thread Iago Toral
On Fri, 2019-01-11 at 11:14 -0600, Jason Ekstrand wrote: > On Fri, Jan 11, 2019 at 9:13 AM Iago Toral Quiroga > wrote: > > We had defined MAX_IMAGES as 8, which we used to size the array for > > > > image push constant data. The comment there stated that this was > > for > > > > gen8, but anv_ni

Re: [Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 9:13 AM Iago Toral Quiroga wrote: > We had defined MAX_IMAGES as 8, which we used to size the array for > image push constant data. The comment there stated that this was for > gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes > that array, asserting tha

Re: [Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Iago Toral
On Fri, 2019-01-11 at 15:24 +, Lionel Landwerlin wrote: > On 11/01/2019 15:12, Iago Toral Quiroga wrote: > > We had defined MAX_IMAGES as 8, which we used to size the array for > > image push constant data. The comment there stated that this was > > for > > gen8, but anv_nir_apply_pipeline_layo

Re: [Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Lionel Landwerlin
On 11/01/2019 15:12, Iago Toral Quiroga wrote: We had defined MAX_IMAGES as 8, which we used to size the array for image push constant data. The comment there stated that this was for gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes that array, asserting that we don't exceed t

[Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Iago Toral Quiroga
We had defined MAX_IMAGES as 8, which we used to size the array for image push constant data. The comment there stated that this was for gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes that array, asserting that we don't exceed that number of images, which imposes a limit of MA