Re: [Mesa-dev] [PATCH v2 9/8] glsl/linker: refactor check_location_aliasing

2017-10-25 Thread Iago Toral
On Wed, 2017-10-25 at 08:35 -0400, Ilia Mirkin wrote: > Not your fault, but this diff is hard to read. On the bright side, 20 > lines removed... Can you confirm that > > layout(location = 1, component = 2) int foo; > layout(location = 0) dvec3 bar; > > fails due to the int vs double conflicts? (I

Re: [Mesa-dev] [PATCH v2 9/8] glsl/linker: refactor check_location_aliasing

2017-10-25 Thread Ilia Mirkin
Not your fault, but this diff is hard to read. On the bright side, 20 lines removed... Can you confirm that layout(location = 1, component = 2) int foo; layout(location = 0) dvec3 bar; fails due to the int vs double conflicts? (I'm specifically interested in the case where the int is specified fi

[Mesa-dev] [PATCH v2 9/8] glsl/linker: refactor check_location_aliasing

2017-10-25 Thread Iago Toral Quiroga
Mostly, this merges the type checks with all the other checks so we only have a single loop for this. --- src/compiler/glsl/link_varyings.cpp | 110 +++- 1 file changed, 46 insertions(+), 64 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compi