Re: [Mesa-dev] [PATCH v2 8/8] mesa: rework the meaning of gl_debug_message::length

2015-11-27 Thread Timothy Arceri
On Thu, 2015-11-26 at 14:31 +, Emil Velikov wrote: > On 26 November 2015 at 05:26, Timothy Arceri > wrote: > > On Thu, 2015-11-26 at 00:36 +, Emil Velikov wrote: > > > Currently it stores strlen(buf) whenever the user originally > > > provided > > > a > > > negative value for length. > > >

Re: [Mesa-dev] [PATCH v2 8/8] mesa: rework the meaning of gl_debug_message::length

2015-11-26 Thread Emil Velikov
On 26 November 2015 at 05:26, Timothy Arceri wrote: > On Thu, 2015-11-26 at 00:36 +, Emil Velikov wrote: >> Currently it stores strlen(buf) whenever the user originally provided >> a >> negative value for length. >> >> Although I've not seen any explicit text in the spec, CTS requires >> that

Re: [Mesa-dev] [PATCH v2 8/8] mesa: rework the meaning of gl_debug_message::length

2015-11-25 Thread Timothy Arceri
On Thu, 2015-11-26 at 00:36 +, Emil Velikov wrote: > Currently it stores strlen(buf) whenever the user originally provided > a > negative value for length. > > Although I've not seen any explicit text in the spec, CTS requires > that > the very same length (be that negative value or not) is re

[Mesa-dev] [PATCH v2 8/8] mesa: rework the meaning of gl_debug_message::length

2015-11-25 Thread Emil Velikov
Currently it stores strlen(buf) whenever the user originally provided a negative value for length. Although I've not seen any explicit text in the spec, CTS requires that the very same length (be that negative value or not) is returned back on Pop. So let's push down the length < 0 checks, tweak