Re: [Mesa-dev] [PATCH v2 6/8] gallium: add lima driver

2019-03-27 Thread Qiang Yu
V3 driver could be reviewed at: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/465 Regards, Qiang On Tue, Mar 26, 2019 at 2:38 PM Qiang Yu wrote: > > On Tue, Mar 26, 2019 at 11:33 AM Alyssa Rosenzweig > wrote: > > > > > + [PPIR_INSTR_SLOT_ALU_VEC_MUL] = ppir_codegen_encode_vec_mul,

Re: [Mesa-dev] [PATCH v2 6/8] gallium: add lima driver

2019-03-25 Thread Qiang Yu
On Tue, Mar 26, 2019 at 11:33 AM Alyssa Rosenzweig wrote: > > > + [PPIR_INSTR_SLOT_ALU_VEC_MUL] = ppir_codegen_encode_vec_mul, > > + [PPIR_INSTR_SLOT_ALU_SCL_MUL] = ppir_codegen_encode_scl_mul, > > + [PPIR_INSTR_SLOT_ALU_VEC_ADD] = ppir_codegen_encode_vec_add, > > + [PPIR_INSTR_SLOT_ALU_SC

Re: [Mesa-dev] [PATCH v2 6/8] gallium: add lima driver

2019-03-25 Thread Alyssa Rosenzweig
> + [PPIR_INSTR_SLOT_ALU_VEC_MUL] = ppir_codegen_encode_vec_mul, > + [PPIR_INSTR_SLOT_ALU_SCL_MUL] = ppir_codegen_encode_scl_mul, > + [PPIR_INSTR_SLOT_ALU_VEC_ADD] = ppir_codegen_encode_vec_add, > + [PPIR_INSTR_SLOT_ALU_SCL_ADD] = ppir_codegen_encode_scl_add, vmul/smul/vadd/sadd are the (o

Re: [Mesa-dev] [PATCH v2 6/8] gallium: add lima driver

2019-03-25 Thread Alyssa Rosenzweig
> Seems Panfrost implementation does not take depth uniforms? That's a /* to-do */ for me; it should definitely be implemented before adding to common code. > we both use the viewport scale/transform vector as the uniform > in this lower pass. I think that's reasonable. I don't like wasting a ha

Re: [Mesa-dev] [PATCH v2 6/8] gallium: add lima driver

2019-03-25 Thread Qiang Yu
On Fri, Mar 22, 2019 at 11:25 PM Alyssa Rosenzweig wrote: > > > + > > +static bool gpir_lower_viewport_transform(gpir_compiler *comp) > > +{ > > + gpir_node *rcpw = NULL; > > + > > + /* rcpw = 1 / w */ > > + list_for_each_entry(gpir_block, block, &comp->block_list, list) { > > + list_fo

Re: [Mesa-dev] [PATCH v2 6/8] gallium: add lima driver

2019-03-22 Thread Alyssa Rosenzweig
> + f->temp_write.dest = 0x03; // 11 - temporary Maybe make a #define, enum [poofs, again] ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 6/8] gallium: add lima driver

2019-03-22 Thread Alyssa Rosenzweig
> + > +static bool gpir_lower_viewport_transform(gpir_compiler *comp) > +{ > + gpir_node *rcpw = NULL; > + > + /* rcpw = 1 / w */ > + list_for_each_entry(gpir_block, block, &comp->block_list, list) { > + list_for_each_entry(gpir_node, node, &block->node_list, list) { > + if (node