Re: [Mesa-dev] [PATCH v2 6/7] intel/isl: Remove tiling checks from choose_msaa_layout

2016-09-23 Thread Nanley Chery
On Mon, Sep 12, 2016 at 05:58:23PM -0700, Jason Ekstrand wrote: > We already do those checks in filter_tiling. There's no good reason to > repeat them in choose_msaa_layout. If anything they should have been > asserts and not "return false" checks. Also, this check was causing us to > outright r

[Mesa-dev] [PATCH v2 6/7] intel/isl: Remove tiling checks from choose_msaa_layout

2016-09-12 Thread Jason Ekstrand
We already do those checks in filter_tiling. There's no good reason to repeat them in choose_msaa_layout. If anything they should have been asserts and not "return false" checks. Also, this check was causing us to outright reject multisampled HiZ surfaces which wasn't intended. Signed-off-by: J