Re: [Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-10 Thread Ilia Mirkin
On Wed, Apr 10, 2019 at 7:31 AM Andres Gomez wrote: > On Wed, 2019-04-10 at 10:40 +1000, Timothy Arceri wrote: > > On 13/2/19 8:57 am, Andres Gomez wrote: > > > @@ -1764,6 +1765,8 @@ struct gl_transform_feedback_buffer > > > > > > uint32_t NumVaryings; > > > > > > + BITSET_WORD *UsedCompone

Re: [Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-10 Thread Andres Gomez
On Wed, 2019-04-10 at 10:40 +1000, Timothy Arceri wrote: > On 13/2/19 8:57 am, Andres Gomez wrote: > > From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: > > > >" No aliasing in output buffers is allowed: It is a compile-time or > > link-time error to specify variables with ove

Re: [Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-09 Thread Timothy Arceri
On 13/2/19 8:57 am, Andres Gomez wrote: From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: " No aliasing in output buffers is allowed: It is a compile-time or link-time error to specify variables with overlapping transform feedback offsets." Currently, this is expected t

Re: [Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-09 Thread Andres Gomez
I'll add locally to the commit log: Fixes the following test: KHR-GL44.enhanced_layouts.xfb_output_overlapping On Tue, 2019-02-12 at 23:57 +0200, Andres Gomez wrote: > From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: > > " No aliasing in output buffers is allowed: It is a compile-t

[Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-02-12 Thread Andres Gomez
From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: " No aliasing in output buffers is allowed: It is a compile-time or link-time error to specify variables with overlapping transform feedback offsets." Currently, this is expected to fail, but it succeeds: " ... la