Re: [Mesa-dev] [PATCH v2 25/37] panfrost: Add a batch fence

2019-09-17 Thread Alyssa Rosenzweig
> > > +/* Start in a signaled state so that even non-submitted batches > > > + * (those that have no draw/clear) can be waited upon. > > > + */ > > > > When would this happen? Presumably if a batch does nothing whatsoever, > > it doesn't make sense to wait on it. > > Was

Re: [Mesa-dev] [PATCH v2 25/37] panfrost: Add a batch fence

2019-09-16 Thread Boris Brezillon
On Mon, 16 Sep 2019 15:38:10 -0400 Alyssa Rosenzweig wrote: > > +/* Start in a signaled state so that even non-submitted batches > > + * (those that have no draw/clear) can be waited upon. > > + */ > > When would this happen? Presumably if a batch does nothing whatsoeve

Re: [Mesa-dev] [PATCH v2 25/37] panfrost: Add a batch fence

2019-09-16 Thread Alyssa Rosenzweig
Also, some typos: > + * since other batches might want to wait on an fence of already a fence. > +/* panfrost_batch_fence is the out fence of batch that users or other batches a batch > +/* Cached value of the signaled state to avoid calling WAIC_SYNCOBJs WAIT_SYNCOBJs ___

Re: [Mesa-dev] [PATCH v2 25/37] panfrost: Add a batch fence

2019-09-16 Thread Alyssa Rosenzweig
> +/* Start in a signaled state so that even non-submitted batches > + * (those that have no draw/clear) can be waited upon. > + */ When would this happen? Presumably if a batch does nothing whatsoever, it doesn't make sense to wait on it. > #include "pan_resource.h" > >

[Mesa-dev] [PATCH v2 25/37] panfrost: Add a batch fence

2019-09-16 Thread Boris Brezillon
So we can implement fine-grained dependency tracking between batches. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_job.c | 51 ++ src/gallium/drivers/panfrost/pan_job.h | 39 2 files changed, 90 insertions(+) diff --git a/src/g