Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Brian Paul
On 10/04/2011 04:08 PM, Kenneth Graunke wrote: On 10/04/2011 12:20 PM, Ian Romanick wrote: On 10/04/2011 10:49 AM, Paul Berry wrote: On 4 October 2011 10:32, Chad Versacemailto:c...@chad-versace.us>> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Overall, the patch looks

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Kenneth Graunke
On 10/04/2011 12:20 PM, Ian Romanick wrote: > On 10/04/2011 10:49 AM, Paul Berry wrote: >> On 4 October 2011 10:32, Chad Versace > > wrote: >> >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Overall, the patch looks good, but I'm going to take the

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/04/2011 12:20 PM, Ian Romanick wrote: > On 10/04/2011 10:49 AM, Paul Berry wrote: >> On 4 October 2011 10:32, Chad Versace > > wrote: >> >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Overall, t

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Ian Romanick
On 10/04/2011 10:49 AM, Paul Berry wrote: On 4 October 2011 10:32, Chad Versace mailto:c...@chad-versace.us>> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Overall, the patch looks good, but I'm going to take the bikeshed bait. Symbols of form GLxxx and constants of form

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Paul Berry
On 4 October 2011 10:32, Chad Versace wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Overall, the patch looks good, but I'm going to take the bikeshed bait. > > Symbols of form GLxxx and constants of form GL_XXX should be reserved for > those defined in the GL headers. If I encounte

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Overall, the patch looks good, but I'm going to take the bikeshed bait. Symbols of form GLxxx and constants of form GL_XXX should be reserved for those defined in the GL headers. If I encountered the symbol GLclipplane in Mesa, I would confidently, ye

[Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-03 Thread Paul Berry
This patch implements proper support for gl_ClipVertex by causing the new VS backend to populate the clip distance VUE slots using VERT_RESULT_CLIP_VERTEX when appropriate, and by using the untransformed clip planes in ctx->Transform.EyeUserPlane rather than the transformed clip planes in ctx->Tran