Re: [Mesa-dev] [PATCH v2 2/2] Replace uses of _mesa_bitcount with util_bitcount

2018-09-06 Thread Eric Anholt
Dylan Baker writes: > and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem > in nir for platforms that don't have popcount or popcountll, such as > 32bit msvc. > > v2: - Fix additional uses of _mesa_bitcount added after this was > originally written Acked-by: Eric Anholt

Re: [Mesa-dev] [PATCH v2 2/2] Replace uses of _mesa_bitcount with util_bitcount

2018-09-06 Thread Dylan Baker
Quoting Dylan Baker (2018-09-06 10:33:36) > Quoting Ian Romanick (2018-09-05 15:58:13) > > After this patch, is 'grep -r _mesa_bitcount' empty? > > I'd left the uses inside src/mesa using _mesa_bitcount, would you like me to > replace those with util_bitcount as well? Doh! Grep led me astray by s

Re: [Mesa-dev] [PATCH v2 2/2] Replace uses of _mesa_bitcount with util_bitcount

2018-09-06 Thread Dylan Baker
Quoting Ian Romanick (2018-09-05 15:58:13) > After this patch, is 'grep -r _mesa_bitcount' empty? I'd left the uses inside src/mesa using _mesa_bitcount, would you like me to replace those with util_bitcount as well? Dylan signature.asc Description: signature ___

Re: [Mesa-dev] [PATCH v2 2/2] Replace uses of _mesa_bitcount with util_bitcount

2018-09-05 Thread Ian Romanick
After this patch, is 'grep -r _mesa_bitcount' empty? On 09/05/2018 02:55 PM, Dylan Baker wrote: > and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem > in nir for platforms that don't have popcount or popcountll, such as > 32bit msvc. > > v2: - Fix additional uses of _mesa_bit

[Mesa-dev] [PATCH v2 2/2] Replace uses of _mesa_bitcount with util_bitcount

2018-09-05 Thread Dylan Baker
and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem in nir for platforms that don't have popcount or popcountll, such as 32bit msvc. v2: - Fix additional uses of _mesa_bitcount added after this was originally written --- src/compiler/glsl/ir_constant_expression.cpp | 2