Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-31 Thread Nanley Chery
On Tue, Jan 30, 2018 at 05:14:39PM -0800, Jason Ekstrand wrote: > On Tue, Jan 30, 2018 at 5:03 PM, Nanley Chery wrote: > > > On Tue, Jan 30, 2018 at 04:25:59PM -0800, Jason Ekstrand wrote: > > > On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery > > wrote: > > > > > > > On Fri, Jan 19, 2018 at 03:47:

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-30 Thread Jason Ekstrand
On Tue, Jan 30, 2018 at 5:03 PM, Nanley Chery wrote: > On Tue, Jan 30, 2018 at 04:25:59PM -0800, Jason Ekstrand wrote: > > On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery > wrote: > > > > > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > > > > Even though the blorp pass looks a b

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-30 Thread Nanley Chery
On Tue, Jan 30, 2018 at 04:25:59PM -0800, Jason Ekstrand wrote: > On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery wrote: > > > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > > > Even though the blorp pass looks a bit on the sketchy side, the end > > > result in the Vulkan driver

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-30 Thread Jason Ekstrand
On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > > Even though the blorp pass looks a bit on the sketchy side, the end > > result in the Vulkan driver is very nice. Instead of having this weird > > case where you do a fast c

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-30 Thread Nanley Chery
On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > Even though the blorp pass looks a bit on the sketchy side, the end > result in the Vulkan driver is very nice. Instead of having this weird > case where you do a fast clear and then maybe have to resolve, we just > do the ambiguate

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-22 Thread Jason Ekstrand
On Mon, Jan 22, 2018 at 2:18 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > > Even though the blorp pass looks a bit on the sketchy side, the end > > result in the Vulkan driver is very nice. Instead of having this we

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-22 Thread Pohjolainen, Topi
On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > Even though the blorp pass looks a bit on the sketchy side, the end > result in the Vulkan driver is very nice. Instead of having this weird > case where you do a fast clear and then maybe have to resolve, we just > do the ambiguate

[Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-19 Thread Jason Ekstrand
Even though the blorp pass looks a bit on the sketchy side, the end result in the Vulkan driver is very nice. Instead of having this weird case where you do a fast clear and then maybe have to resolve, we just do the ambiguate and are done with it. The ambiguate does exactly what we want of setti