Re: [Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-21 Thread Timothy Arceri
On 21/11/17 15:54, Timothy Arceri wrote: On 21/11/17 15:34, Jordan Justen wrote: On 2017-11-20 19:00:28, Timothy Arceri wrote: I don't think this belongs in util. disk cache is generic and used by both Vulkan and Opengl drivers. These function are specific to one OpenGL extension and have a dep

Re: [Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-20 Thread Timothy Arceri
On 21/11/17 15:34, Jordan Justen wrote: On 2017-11-20 19:00:28, Timothy Arceri wrote: I don't think this belongs in util. disk cache is generic and used by both Vulkan and Opengl drivers. These function are specific to one OpenGL extension and have a dependency on OpenGL types. I think you shoul

Re: [Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-20 Thread Jordan Justen
On 2017-11-20 19:00:28, Timothy Arceri wrote: > I don't think this belongs in util. disk cache is generic and used by > both Vulkan and Opengl drivers. These function are specific to one > OpenGL extension and have a dependency on OpenGL types. I think you > should just move this inside the src/

Re: [Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-20 Thread Timothy Arceri
I don't think this belongs in util. disk cache is generic and used by both Vulkan and Opengl drivers. These function are specific to one OpenGL extension and have a dependency on OpenGL types. I think you should just move this inside the src/mesa, I can't see this being reused anywhere else. Ma

[Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-20 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/util/Makefile.sources | 2 + src/util/meson.build | 2 + src/util/program_binary.c | 149 ++ src/util/program_binary.h | 70 ++ 4 files changed, 223 insertions(+) create mode 100644 src