Re: [Mesa-dev] [PATCH v2 10/18] intel/compiler: fix 16-bit comparisons

2018-05-01 Thread Iago Toral
On Mon, 2018-04-30 at 14:43 -0700, Jason Ekstrand wrote: > On Mon, Apr 30, 2018 at 7:18 AM, Iago Toral Quiroga m> wrote: > > NIR assumes that booleans are always 32-bit, but Intel hardware > > produces > > > > 16-bit booleans for 16-bit comparisons. This means that we need to > > convert > > > >

Re: [Mesa-dev] [PATCH v2 10/18] intel/compiler: fix 16-bit comparisons

2018-04-30 Thread Jason Ekstrand
On Mon, Apr 30, 2018 at 7:18 AM, Iago Toral Quiroga wrote: > NIR assumes that booleans are always 32-bit, but Intel hardware produces > 16-bit booleans for 16-bit comparisons. This means that we need to convert > the 16-bit result to 32-bit. > > In the future we want to add an optimization pass t

[Mesa-dev] [PATCH v2 10/18] intel/compiler: fix 16-bit comparisons

2018-04-30 Thread Iago Toral Quiroga
NIR assumes that booleans are always 32-bit, but Intel hardware produces 16-bit booleans for 16-bit comparisons. This means that we need to convert the 16-bit result to 32-bit. In the future we want to add an optimization pass to clean this up and hopefully remove the conversions. --- src/intel/c