Re: [Mesa-dev] [PATCH v2 1/9] panfrost: Make ctx->job useful

2019-08-10 Thread Juan A. Suarez Romero
On Thu, 2019-08-08 at 15:28 +0200, Boris Brezillon wrote: > On Thu, 8 Aug 2019 06:08:05 -0700 > Alyssa Rosenzweig wrote: > > > @Boris I don't see why this patch particularly needs to be backported to > > 19.1? > > Nope, no reason to backport it to 19.1. It's just a (bad?) kernel dev > habit to p

Re: [Mesa-dev] [PATCH v2 1/9] panfrost: Make ctx->job useful

2019-08-08 Thread Boris Brezillon
On Thu, 8 Aug 2019 06:08:05 -0700 Alyssa Rosenzweig wrote: > @Boris I don't see why this patch particularly needs to be backported to > 19.1? Nope, no reason to backport it to 19.1. It's just a (bad?) kernel dev habit to put "Fixes:" tag the patch fixes a problem introduced by a previous commit.

Re: [Mesa-dev] [PATCH v2 1/9] panfrost: Make ctx->job useful

2019-08-08 Thread Alyssa Rosenzweig
@Boris I don't see why this patch particularly needs to be backported to 19.1? On Thu, Aug 08, 2019 at 11:46:43AM +0200, Juan A. Suarez Romero wrote: > On Fri, 2019-08-02 at 19:18 +0200, Boris Brezillon wrote: > > ctx->job is supposed to serve as a cache to avoid an hash table lookup > > everytime

Re: [Mesa-dev] [PATCH v2 1/9] panfrost: Make ctx->job useful

2019-08-08 Thread Juan A. Suarez Romero
On Fri, 2019-08-02 at 19:18 +0200, Boris Brezillon wrote: > ctx->job is supposed to serve as a cache to avoid an hash table lookup > everytime we access the job attached to the currently bound FB, except > it was never assigned to anything but NULL. > > Fix that by adding the missing assignment in

Re: [Mesa-dev] [PATCH v2 1/9] panfrost: Make ctx->job useful

2019-08-02 Thread Alyssa Rosenzweig
R-b! Nice! :) signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 1/9] panfrost: Make ctx->job useful

2019-08-02 Thread Boris Brezillon
ctx->job is supposed to serve as a cache to avoid an hash table lookup everytime we access the job attached to the currently bound FB, except it was never assigned to anything but NULL. Fix that by adding the missing assignment in panfrost_get_job_for_fbo(). Also add a missing NULL assignment in t