Re: [Mesa-dev] [PATCH v2 1/2] r600: correct texture offset for array index lookup

2018-06-29 Thread Gert Wollny
Am Freitag, den 29.06.2018, 17:42 +0200 schrieb Roland Scheidegger: [...] Thanks for the review > > So for gather4_O (where you'd need to do it differently) it must not > be > done, but for gather4 it has to be done? > Still doesn't make all that much sense to me. The hw may be weird but > I don

Re: [Mesa-dev] [PATCH v2 1/2] r600: correct texture offset for array index lookup

2018-06-29 Thread Roland Scheidegger
Am 29.06.2018 um 16:35 schrieb Gert Wollny: > For texture array lookup the slice index is evaluated according to > idx = floor(z + 0.5) > > This patch implements the first part by adding 0.5 to the according > texture coordinate when appropriate. > > Fixes multi-sample tests out of: > dEQP-GL

[Mesa-dev] [PATCH v2 1/2] r600: correct texture offset for array index lookup

2018-06-29 Thread Gert Wollny
For texture array lookup the slice index is evaluated according to idx = floor(z + 0.5) This patch implements the first part by adding 0.5 to the according texture coordinate when appropriate. Fixes multi-sample tests out of: dEQP-GLES3.functional.texture.shadow.2d_array.* dEQP-GLES3.functi