Re: [Mesa-dev] [PATCH v2 1/2] egl/dri2: Close file descriptor on error.

2015-09-09 Thread Ian Romanick
On 09/09/2015 10:59 AM, Emil Velikov wrote: > On 9 September 2015 at 01:43, Ian Romanick wrote: >> On 09/07/2015 01:58 AM, Emil Velikov wrote: >>> From: Matt Turner >>> >>> v2: [Emil Velikov] >>> Rework the error path to a common goto, close only if we own the fd. >>> >>> Signed-off-by: Emil Veli

Re: [Mesa-dev] [PATCH v2 1/2] egl/dri2: Close file descriptor on error.

2015-09-09 Thread Emil Velikov
On 9 September 2015 at 01:43, Ian Romanick wrote: > On 09/07/2015 01:58 AM, Emil Velikov wrote: >> From: Matt Turner >> >> v2: [Emil Velikov] >> Rework the error path to a common goto, close only if we own the fd. >> >> Signed-off-by: Emil Velikov >> --- >> src/egl/drivers/dri2/platform_drm.c |

Re: [Mesa-dev] [PATCH v2 1/2] egl/dri2: Close file descriptor on error.

2015-09-08 Thread Ian Romanick
On 09/07/2015 01:58 AM, Emil Velikov wrote: > From: Matt Turner > > v2: [Emil Velikov] > Rework the error path to a common goto, close only if we own the fd. > > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/platform_drm.c | 27 ++- > 1 file changed, 14 inser

Re: [Mesa-dev] [PATCH v2 1/2] egl/dri2: Close file descriptor on error.

2015-09-07 Thread Boyan Ding
2015-09-07 16:58 GMT+08:00 Emil Velikov : > From: Matt Turner > > v2: [Emil Velikov] > Rework the error path to a common goto, close only if we own the fd. > > Signed-off-by: Emil Velikov Reviewed-by: Boyan Ding > --- > src/egl/drivers/dri2/platform_drm.c | 27 ++- > 1

[Mesa-dev] [PATCH v2 1/2] egl/dri2: Close file descriptor on error.

2015-09-07 Thread Emil Velikov
From: Matt Turner v2: [Emil Velikov] Rework the error path to a common goto, close only if we own the fd. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/egl/drivers/dri2/p