Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-09 Thread Ian Romanick
On 02/07/2015 05:25 PM, Matt Turner wrote: > On Sat, Feb 7, 2015 at 5:16 PM, Ilia Mirkin wrote: >> On Sat, Feb 7, 2015 at 8:10 PM, Ilia Mirkin wrote: > diff --git a/src/glsl/ir.h b/src/glsl/ir.h > index a0f48b2..6e7c654 100644 > --- a/src/glsl/ir.h > +++ b/src/glsl/ir.h > @@ -

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-07 Thread Ilia Mirkin
On Sat, Feb 7, 2015 at 8:25 PM, Matt Turner wrote: > On Sat, Feb 7, 2015 at 5:16 PM, Ilia Mirkin wrote: >> On Sat, Feb 7, 2015 at 8:10 PM, Ilia Mirkin wrote: > diff --git a/src/glsl/ir.h b/src/glsl/ir.h > index a0f48b2..6e7c654 100644 > --- a/src/glsl/ir.h > +++ b/src/glsl/ir.h >

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-07 Thread Matt Turner
On Sat, Feb 7, 2015 at 5:16 PM, Ilia Mirkin wrote: > On Sat, Feb 7, 2015 at 8:10 PM, Ilia Mirkin wrote: diff --git a/src/glsl/ir.h b/src/glsl/ir.h index a0f48b2..6e7c654 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.h @@ -1275,6 +1275,13 @@ enum ir_expression_operation { >

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-07 Thread Ilia Mirkin
On Sat, Feb 7, 2015 at 8:10 PM, Ilia Mirkin wrote: >>> diff --git a/src/glsl/ir.h b/src/glsl/ir.h >>> index a0f48b2..6e7c654 100644 >>> --- a/src/glsl/ir.h >>> +++ b/src/glsl/ir.h >>> @@ -1275,6 +1275,13 @@ enum ir_expression_operation { >>> ir_unop_bitcast_f2u, /**< Bit-identical float-to-uin

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-07 Thread Ilia Mirkin
On Fri, Feb 6, 2015 at 2:47 AM, Ian Romanick wrote: > There's a bunch of tabs that should be replaced with spaces. S... this whole mixed tab/space situation is quite annoying. A lot of lines come from copying other stuff, and having to fix up tabs on those can be quite a bother. I'd be happy

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-06 Thread Ian Romanick
On 02/06/2015 10:44 AM, Matt Turner wrote: > On Thu, Feb 5, 2015 at 11:47 PM, Ian Romanick wrote: >>> diff --git a/src/glsl/ir.h b/src/glsl/ir.h >>> index a0f48b2..6e7c654 100644 >>> --- a/src/glsl/ir.h >>> +++ b/src/glsl/ir.h >>> @@ -1275,6 +1275,13 @@ enum ir_expression_operation { >>> ir_un

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-06 Thread Matt Turner
On Thu, Feb 5, 2015 at 11:47 PM, Ian Romanick wrote: >> diff --git a/src/glsl/ir.h b/src/glsl/ir.h >> index a0f48b2..6e7c654 100644 >> --- a/src/glsl/ir.h >> +++ b/src/glsl/ir.h >> @@ -1275,6 +1275,13 @@ enum ir_expression_operation { >> ir_unop_bitcast_f2u, /**< Bit-identical float-to-uint "c

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-05 Thread Ian Romanick
There's a bunch of tabs that should be replaced with spaces. Other comments below... On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/glsl/ir.cpp | 104 > ++-- > src/glsl/ir.h

[Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

2015-02-05 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/ir.cpp | 104 ++-- src/glsl/ir.h | 21 src/glsl/ir_validate.cpp| 68 +++--- src/mesa/program/ir_to_mesa.cpp | 10 4 files