Re: [Mesa-dev] [PATCH v2 06/41] ac/nir: fix 16-bit ssbo stores

2019-02-26 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 2/18/19 2:23 PM, Rhys Perry wrote: I don't see a 16-bit version of tbuffer.store in IntrinsicsAMDGPU.td and simply changing "llvm.amdgcn.tbuffer.store.i32" to "llvm.amdgcn.tbuffer.store.i16" and removing the zext doesn't seem to work. On Mon, 18 Feb 2019 at 08:5

Re: [Mesa-dev] [PATCH v2 06/41] ac/nir: fix 16-bit ssbo stores

2019-02-18 Thread Rhys Perry
I don't see a 16-bit version of tbuffer.store in IntrinsicsAMDGPU.td and simply changing "llvm.amdgcn.tbuffer.store.i32" to "llvm.amdgcn.tbuffer.store.i16" and removing the zext doesn't seem to work. On Mon, 18 Feb 2019 at 08:55, Samuel Pitoiset wrote: > > Does this fix anything know? There is a

Re: [Mesa-dev] [PATCH v2 06/41] ac/nir: fix 16-bit ssbo stores

2019-02-18 Thread Samuel Pitoiset
Does this fix anything know? There is a 16-bit version of tbuffer.store, maybe we should use it? On 2/16/19 1:21 AM, Rhys Perry wrote: Signed-off-by: Rhys Perry --- src/amd/common/ac_nir_to_llvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/am

[Mesa-dev] [PATCH v2 06/41] ac/nir: fix 16-bit ssbo stores

2019-02-15 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/amd/common/ac_nir_to_llvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 89a78b43c6f..b260142c177 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @