Re: [Mesa-dev] [PATCH v2 05/78] i965/nir/vec4: Add setup of uniform variables

2015-07-23 Thread Jason Ekstrand
You seem to switch back and forth between "uniforms" and "this->uniforms". It would be nice to be consistent. On Thu, Jul 23, 2015 at 3:16 AM, Eduardo Lima Mitev wrote: > From: Iago Toral Quiroga > > This is based on similar code existing in vec4_visitor. It builds the > uniform register file i

[Mesa-dev] [PATCH v2 05/78] i965/nir/vec4: Add setup of uniform variables

2015-07-23 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga This is based on similar code existing in vec4_visitor. It builds the uniform register file iterating through each uniform variable. It also stores the index of each register at the corresponding offset in a map. This map will later be used by load_uniform intrinsic instr