Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-11-23 Thread Wladimir J. van der Laan
> Can confirm that this completely breaks rendering on GC3000. > > I don't know how this happened, I'm sure I tested this before :( maybe > with a slightly different version of the patch stack. Solved! Etnaviv is emitting vertex stream attributes in an unconvential way: - Write vertex stream ad

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-11-23 Thread Wladimir J. van der Laan
On Wed, Nov 22, 2017 at 07:29:18PM +0100, Wladimir J. van der Laan wrote: > > > I would really like to know what's wrong with this patch, as using the > > new draw command should be fine on GC3000 and we certainly want to > > support instanced drawing at some point. > > Did you also apply the "et

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-11-22 Thread Wladimir J. van der Laan
> I would really like to know what's wrong with this patch, as using the > new draw command should be fine on GC3000 and we certainly want to > support instanced drawing at some point. Did you also apply the "etnaviv: Emit SCALE for vertex attributes" patch? If so maybe there's something wrong w

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-11-22 Thread Lucas Stach
Am Mittwoch, den 22.11.2017, 18:16 +0100 schrieb Wladimir J. van der Laan: > Hello Lucas, > > On Wed, Nov 22, 2017 at 02:29:33PM +0100, Lucas Stach wrote: > > Hi Wladimir, > > > > Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan: > > > The blob does this, as DRAW_INSTANCED

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-11-22 Thread Wladimir J. van der Laan
Hello Lucas, On Wed, Nov 22, 2017 at 02:29:33PM +0100, Lucas Stach wrote: > Hi Wladimir, > > Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan: > > The blob does this, as DRAW_INSTANCED can replace fully all the other > > draw commands. It is also required to handle integer

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-11-22 Thread Lucas Stach
Hi Wladimir, Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan: > The blob does this, as DRAW_INSTANCED can replace fully all the other > draw commands. It is also required to handle integer vertex formats. > The other path is only there for compatibility and might go away (

[Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-11-18 Thread Wladimir J. van der Laan
The blob does this, as DRAW_INSTANCED can replace fully all the other draw commands. It is also required to handle integer vertex formats. The other path is only there for compatibility and might go away (or at least rot to become buggy due to dis-use) in newer hardware. As a by-effect this change