Re: [Mesa-dev] [PATCH v2 02/24] anv: do not try to ref/unref NULL shaders

2017-03-14 Thread Iago Toral
On Tue, 2017-03-14 at 10:22 +0200, Pohjolainen, Topi wrote: > On Fri, Mar 10, 2017 at 01:38:15PM +0100, Iago Toral Quiroga wrote: > > > > This situation can happen if we failed to allocate memory for the > > shader. > > > > v2: > >  - We shouldn't see NULL shaders in anv_shader_bin_ref so we shou

Re: [Mesa-dev] [PATCH v2 02/24] anv: do not try to ref/unref NULL shaders

2017-03-14 Thread Pohjolainen, Topi
On Fri, Mar 10, 2017 at 01:38:15PM +0100, Iago Toral Quiroga wrote: > This situation can happen if we failed to allocate memory for the shader. > > v2: > - We shouldn't see NULL shaders in anv_shader_bin_ref so we should not check >for that (Jason). Make sure that callers don't attempt to cal

[Mesa-dev] [PATCH v2 02/24] anv: do not try to ref/unref NULL shaders

2017-03-10 Thread Iago Toral Quiroga
This situation can happen if we failed to allocate memory for the shader. v2: - We shouldn't see NULL shaders in anv_shader_bin_ref so we should not check for that (Jason). Make sure that callers don't attempt to call this function with a NULL shader and assert that this never happens (Iago