Re: [Mesa-dev] [PATCH v2 01/10] swr: [rasterizer codegen] Refactor codegen

2017-03-28 Thread Emil Velikov
Hi Tim, On 27 March 2017 at 17:17, Tim Rowley wrote: > Move common codegen functions into gen_common.py. > > v2: change gen_knobs.py to find the template file internally, like > the rest of the gen scripts. Hard-coding file names and location inside generator scripts is bad idea. I'd kindly urge

Re: [Mesa-dev] [PATCH v2 01/10] swr: [rasterizer codegen] Refactor codegen

2017-03-28 Thread Cherniak, Bruce
In light of dropping patch 10/10 (for now), this patch stands as-is. Windows/SCONS build will be addressed in a followup. This patch: Reviewed-by: Bruce Cherniak mailto:bruce.chern...@intel.com>> On Mar 27, 2017, at 7:35 PM, Kyriazis, George mailto:george.kyria...@intel.com>> wrote: With thi

Re: [Mesa-dev] [PATCH v2 01/10] swr: [rasterizer codegen] Refactor codegen

2017-03-27 Thread Kyriazis, George
With this v2 change PATCH 10/10 has to be updated. V2 of 10/10 coming in a separate envelope. With the 10/10 update, this patch: Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> George On Mar 27, 2017, at 11:17 AM, Tim Rowley mailto:timothy.o.row...@intel.com>> wrote: Move c

[Mesa-dev] [PATCH v2 01/10] swr: [rasterizer codegen] Refactor codegen

2017-03-27 Thread Tim Rowley
Move common codegen functions into gen_common.py. v2: change gen_knobs.py to find the template file internally, like the rest of the gen scripts. --- src/gallium/drivers/swr/Makefile.am| 20 ++- .../drivers/swr/rasterizer/codegen/gen_archrast.py | 30 +--- .../drivers/swr/raster