Re: [Mesa-dev] [PATCH v2 00/37] panfrost: Support batch pipelining

2019-09-18 Thread Boris Brezillon
+Rob On Tue, 17 Sep 2019 17:13:04 +0200 Boris Brezillon wrote: > On Tue, 17 Sep 2019 08:36:56 -0400 > Alyssa Rosenzweig wrote: > > > "Can't use pipe_framebuffer_state as a hash key" Is this still relevant? > > I thought we did this. > > I did this yes. I thought it was only a problem for th

Re: [Mesa-dev] [PATCH v2 00/37] panfrost: Support batch pipelining

2019-09-17 Thread Boris Brezillon
On Tue, 17 Sep 2019 08:36:56 -0400 Alyssa Rosenzweig wrote: > "Can't use pipe_framebuffer_state as a hash key" Is this still relevant? > I thought we did this. I did this yes. I thought it was only a problem for the wallpaper draw, but it's actually wrong for any kind of blit where src and dst p

Re: [Mesa-dev] [PATCH v2 00/37] panfrost: Support batch pipelining

2019-09-17 Thread Alyssa Rosenzweig
"Can't use pipe_framebuffer_state as a hash key" Is this still relevant? I thought we did this. You're right that the 32-batch bitset is something we can integrate in a v2. I guess that's it, never mind. Good stuff regardless :) On Tue, Sep 17, 2019 at 12:08:34AM +0200, Boris Brezillon wrote: >

Re: [Mesa-dev] [PATCH v2 00/37] panfrost: Support batch pipelining

2019-09-16 Thread Boris Brezillon
On Mon, 16 Sep 2019 16:29:05 -0400 Alyssa Rosenzweig wrote: > > As a drive-by comment, in case you didn't know, the "standard" > > solution for avoiding flushing when BO's are written by the CPU (e.g. > > uniform buffer updates) as documented in ARM's performance guide is to > > add a copy-on-wri

Re: [Mesa-dev] [PATCH v2 00/37] panfrost: Support batch pipelining

2019-09-16 Thread Alyssa Rosenzweig
> As a drive-by comment, in case you didn't know, the "standard" > solution for avoiding flushing when BO's are written by the CPU (e.g. > uniform buffer updates) as documented in ARM's performance guide is to > add a copy-on-write mechanism, so that you have "shadow" BO's when the > original BO is

Re: [Mesa-dev] [PATCH v2 00/37] panfrost: Support batch pipelining

2019-09-16 Thread Boris Brezillon
On Mon, 16 Sep 2019 17:11:01 +0700 Connor Abbott wrote: > As a drive-by comment, in case you didn't know, the "standard" > solution for avoiding flushing when BO's are written by the CPU (e.g. > uniform buffer updates) as documented in ARM's performance guide is to > add a copy-on-write mechanism

Re: [Mesa-dev] [PATCH v2 00/37] panfrost: Support batch pipelining

2019-09-16 Thread Connor Abbott
As a drive-by comment, in case you didn't know, the "standard" solution for avoiding flushing when BO's are written by the CPU (e.g. uniform buffer updates) as documented in ARM's performance guide is to add a copy-on-write mechanism, so that you have "shadow" BO's when the original BO is modified

[Mesa-dev] [PATCH v2 00/37] panfrost: Support batch pipelining

2019-09-16 Thread Boris Brezillon
Hello, This is the second attempt at supporting batch pipelining. This time I implemented it using a dependency graph (as suggested by Alyssa and Steven) so that batch submission can be delayed even more: the only time we flush batches now is when we have an explicit flush or when the CPU needs to