Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

2017-07-27 Thread Kyriazis, George
> On Jul 27, 2017, at 1:49 PM, Ilia Mirkin wrote: > > On Thu, Jul 27, 2017 at 2:45 PM, Kyriazis, George > wrote: >> >> On Jul 27, 2017, at 1:25 PM, Ilia Mirkin wrote: >> >> On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis >> wrote: >> >> The shader that is used to copy vertex data out of t

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

2017-07-27 Thread Ilia Mirkin
On Thu, Jul 27, 2017 at 2:45 PM, Kyriazis, George wrote: > > On Jul 27, 2017, at 1:25 PM, Ilia Mirkin wrote: > > On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis > wrote: > > The shader that is used to copy vertex data out of the vs/gs shaders to > the user-specified buffer (streamout or SO shad

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

2017-07-27 Thread Kyriazis, George
On Jul 27, 2017, at 1:25 PM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis mailto:george.kyria...@intel.com>> wrote: The shader that is used to copy vertex data out of the vs/gs shaders to the user-specified buffer (streamout or SO shader) was

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

2017-07-27 Thread Ilia Mirkin
On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis wrote: > The shader that is used to copy vertex data out of the vs/gs shaders to > the user-specified buffer (streamout or SO shader) was not using the > correct offsets. > > Adjust the offsets that are used just for the SO shader: > - Make sure tha

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

2017-07-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jul 26, 2017, at 5:27 PM, George Kyriazis > wrote: > > The shader that is used to copy vertex data out of the vs/gs shaders to > the user-specified buffer (streamout or SO shader) was not using the > correct offsets. > > Adjust the offsets that are used just

[Mesa-dev] [PATCH v2] swr: fix transform feedback logic

2017-07-26 Thread George Kyriazis
The shader that is used to copy vertex data out of the vs/gs shaders to the user-specified buffer (streamout or SO shader) was not using the correct offsets. Adjust the offsets that are used just for the SO shader: - Make sure that position is handled in the same special way as in the vs/gs shad