Re: [Mesa-dev] [PATCH v2] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Dave Airlie
On 26 June 2017 at 06:55, Bas Nieuwenhuizen wrote: > On Sun, Jun 25, 2017 at 10:29 PM, Dave Airlie wrote: >> On 26 June 2017 at 06:19, Bas Nieuwenhuizen wrote: >>> v2: Don't pass layout to image view usage mask. >>> >>> Signed-off-by: Bas Nieuwenhuizen >>> Fixes: 0628580eff6 "radv: Specify sema

Re: [Mesa-dev] [PATCH v2] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Bas Nieuwenhuizen
On Sun, Jun 25, 2017 at 10:29 PM, Dave Airlie wrote: > On 26 June 2017 at 06:19, Bas Nieuwenhuizen wrote: >> v2: Don't pass layout to image view usage mask. >> >> Signed-off-by: Bas Nieuwenhuizen >> Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." > > Just wondering what thi

Re: [Mesa-dev] [PATCH v2] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Dave Airlie
On 26 June 2017 at 06:19, Bas Nieuwenhuizen wrote: > v2: Don't pass layout to image view usage mask. > > Signed-off-by: Bas Nieuwenhuizen > Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." Just wondering what this actually fixes, I've mostly left GENERAL in use in meta as it

[Mesa-dev] [PATCH v2] radv: Use correct image layout for blit based copies.

2017-06-25 Thread Bas Nieuwenhuizen
v2: Don't pass layout to image view usage mask. Signed-off-by: Bas Nieuwenhuizen Fixes: 0628580eff6 "radv: Specify semantics of HTILE layout helpers." --- src/amd/vulkan/radv_meta_blit2d.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/amd/vulkan/r