Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-03 Thread Andy Furniss
The v4 version of the patch that was committed still has regressed build for me. Reverting and applying v2 still builds OK. I now get - Making all in targets/opencl make[4]: Entering directory '/mnt/sdb1/Gits/mesa/src/gallium/targets/opencl' CXXLDlibOpenCL.la ../../../../src/util/.libs/l

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-03 Thread Nicolai Hähnle
On 02.08.2017 22:44, Jan Vesely wrote: probably. The original changeset passes NULL(which is then unconditionally accessed) at least in: src/gallium/auxiliary/vl/vl_winsys_dri.c src/gallium/auxiliary/vl/vl_winsys_dri3.c src/gallium/auxiliary/vl/vl_winsys_drm.c src/gallium/state_trackers/xa/xa_tr

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Jan Vesely
probably. The original changeset passes NULL(which is then unconditionally accessed) at least in: src/gallium/auxiliary/vl/vl_winsys_dri.c src/gallium/auxiliary/vl/vl_winsys_dri3.c src/gallium/auxiliary/vl/vl_winsys_drm.c src/gallium/state_trackers/xa/xa_tracker.c src/gallium/targets/d3dadapter9/d

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Andy Furniss
Hmm, been AFK, but now have actually installed as well as just testing build. Testing with this and the patch that avoids segfaults for cl. I am getting segfaults when using vdpau for video, so maybe that needs something similar. Jan Vesely wrote: The patch still causes segfaults because yo

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Jan Vesely
The patch still causes segfaults because you pass NULL at core/device.cpp:45 yet unconditionally access the pointer at pipe_loader.c:130 Jan On Wed, 2017-08-02 at 18:44 +0200, Nicolai Hähnle wrote: > Thanks! I'll take that as a Tested-by. > > On 02.08.2017 18:43, Andy Furniss wrote: > > Building

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Nicolai Hähnle
Thanks! I'll take that as a Tested-by. On 02.08.2017 18:43, Andy Furniss wrote: Building OK with this. Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions")

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Andy Furniss
Building OK with this. Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014 -- I believe this is

[Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014 -- I believe this is the right place to add it; the error reported by