Re: [Mesa-dev] [PATCH v2] nir: fix output offset compute for dvec3/4

2018-11-09 Thread Jason Ekstrand
Cool. 1-3 are Reviewed-by: Jason Ekstrand On Fri, Nov 9, 2018 at 7:09 AM Alejandro Piñeiro wrote: > The offset compute was working fine for the case of attrib_slots=1, > and updating the offset for the following varying. > > But in the case of attrib_slots=2 (so dvec3/4), we are basically > s

[Mesa-dev] [PATCH v2] nir: fix output offset compute for dvec3/4

2018-11-09 Thread Alejandro Piñeiro
The offset compute was working fine for the case of attrib_slots=1, and updating the offset for the following varying. But in the case of attrib_slots=2 (so dvec3/4), we are basically splitting the comp_slots needed in two outputs. In that case we can't add to the offset the full size of the type.