Re: [Mesa-dev] [PATCH v2] nir: fix nir_copy_propagation test

2018-10-23 Thread Vinson Lee
On Tue, Oct 23, 2018 at 7:56 AM Juan A. Suarez Romero wrote: > > Use nir_src_comp_as_uint() to read the proper second component, as > nir_src_as_uint() returns the first one. > > v2: Use nir_src_comp_as_uint() [Jason] > > Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core >

Re: [Mesa-dev] [PATCH v2] nir: fix nir_copy_propagation test

2018-10-23 Thread Jason Ekstrand
Please CC and close https://bugs.freedesktop.org/show_bug.cgi?id=108532 when you push this. --Jason On Tue, Oct 23, 2018 at 12:12 PM Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Tue, Oct 23, 2018 at 9:55 AM Juan A. Suarez Romero > wrote: > >> Use nir_src_comp_as_uint() to read t

Re: [Mesa-dev] [PATCH v2] nir: fix nir_copy_propagation test

2018-10-23 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Oct 23, 2018 at 9:55 AM Juan A. Suarez Romero wrote: > Use nir_src_comp_as_uint() to read the proper second component, as > nir_src_as_uint() returns the first one. > > v2: Use nir_src_comp_as_uint() [Jason] > > Fixes: 16870de8a0a ("nir: Use nir_src_is_const

Re: [Mesa-dev] [PATCH v2] nir: fix nir_copy_propagation test

2018-10-23 Thread Michel Dänzer
On 2018-10-23 4:55 p.m., Juan A. Suarez Romero wrote: > Use nir_src_comp_as_uint() to read the proper second component, as > nir_src_as_uint() returns the first one. > > v2: Use nir_src_comp_as_uint() [Jason] > > Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core >

[Mesa-dev] [PATCH v2] nir: fix nir_copy_propagation test

2018-10-23 Thread Juan A. Suarez Romero
Use nir_src_comp_as_uint() to read the proper second component, as nir_src_as_uint() returns the first one. v2: Use nir_src_comp_as_uint() [Jason] Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core code") Signed-off-by: Juan A. Suarez Romero --- src/com