Re: [Mesa-dev] [PATCH v2] nir: fix compacting varyings when XFB outputs are present

2018-10-11 Thread Timothy Arceri
On 11/10/18 6:59 pm, Samuel Pitoiset wrote: On 10/10/18 11:46 PM, Timothy Arceri wrote: On 11/10/18 1:46 am, Samuel Pitoiset wrote: We shouldn't try to compact any varyings known as always active IO, especially XFB outputs. For example, if one component of an xfb output is also used as inpu

Re: [Mesa-dev] [PATCH v2] nir: fix compacting varyings when XFB outputs are present

2018-10-11 Thread Samuel Pitoiset
On 10/10/18 11:46 PM, Timothy Arceri wrote: On 11/10/18 1:46 am, Samuel Pitoiset wrote: We shouldn't try to compact any varyings known as always active IO, especially XFB outputs. For example, if one component of an xfb output is also used as input varying in the next stage, it shouldn't be

Re: [Mesa-dev] [PATCH v2] nir: fix compacting varyings when XFB outputs are present

2018-10-10 Thread Timothy Arceri
On 11/10/18 1:46 am, Samuel Pitoiset wrote: We shouldn't try to compact any varyings known as always active IO, especially XFB outputs. For example, if one component of an xfb output is also used as input varying in the next stage, it shouldn't be compacted. This small helper just marks all XF

[Mesa-dev] [PATCH v2] nir: fix compacting varyings when XFB outputs are present

2018-10-10 Thread Samuel Pitoiset
We shouldn't try to compact any varyings known as always active IO, especially XFB outputs. For example, if one component of an xfb output is also used as input varying in the next stage, it shouldn't be compacted. This small helper just marks all XFB varyings as always_active_io in the consumer t