Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-24 Thread Jason Ekstrand
On Fri, Feb 24, 2017 at 8:33 AM, tournier.elie wrote: > Ping. > > > On 13 February 2017 at 10:17, tournier.elie > wrote: > >> Whoops I answer 2 times. >> >> Would the comment bellow be appropriate? >> >> This limit is chosen fairly arbitrarily. >> GLSL IR max iteration is 32 instructions. (Multi

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-24 Thread tournier.elie
Ping. On 13 February 2017 at 10:17, tournier.elie wrote: > Whoops I answer 2 times. > > Would the comment bellow be appropriate? > > This limit is chosen fairly arbitrarily. > GLSL IR max iteration is 32 instructions. (Multiply counting nodes and > magic number 5). > But there is no 1:1 mapping

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-13 Thread tournier.elie
Whoops I answer 2 times. Would the comment bellow be appropriate? This limit is chosen fairly arbitrarily. GLSL IR max iteration is 32 instructions. (Multiply counting nodes and magic number 5). But there is no 1:1 mapping between GLSL IR and NIR so 25 was picked because it seemed to give about t

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-12 Thread tournier.elie
On 9 February 2017 at 02:48, Timothy Arceri wrote: > On Wed, 8 Feb 2017 15:54:46 -0800 > Jason Ekstrand wrote: > > > On Wed, Feb 8, 2017 at 2:20 PM, Elie Tournier > > wrote: > > > > > Signed-off-by: Elie Tournier > > > --- > > > src/compiler/nir/nir_opt_loop_unroll.c | 10 +- > > > 1

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-09 Thread Timothy Arceri
On Wed, 2017-02-08 at 15:54 -0800, Jason Ekstrand wrote: > On Wed, Feb 8, 2017 at 2:20 PM, Elie Tournier m> wrote: > > Signed-off-by: Elie Tournier > > --- > >  src/compiler/nir/nir_opt_loop_unroll.c | 10 +- > >  1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/src/com

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-08 Thread Timothy Arceri
On Wed, 8 Feb 2017 15:54:46 -0800 Jason Ekstrand wrote: > On Wed, Feb 8, 2017 at 2:20 PM, Elie Tournier > wrote: > > > Signed-off-by: Elie Tournier > > --- > > src/compiler/nir/nir_opt_loop_unroll.c | 10 +- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/src/c

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-08 Thread Jason Ekstrand
On Wed, Feb 8, 2017 at 2:20 PM, Elie Tournier wrote: > Signed-off-by: Elie Tournier > --- > src/compiler/nir/nir_opt_loop_unroll.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir_opt_loop_unroll.c > b/src/compiler/nir/nir_opt_loop_unroll.c

[Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-08 Thread Elie Tournier
Signed-off-by: Elie Tournier --- src/compiler/nir/nir_opt_loop_unroll.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_loop_unroll.c b/src/compiler/nir/nir_opt_loop_unroll.c index 37cbced43d..035a030239 100644 --- a/src/compiler/nir/nir_opt