Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Ian Romanick
On 03/16/2018 01:58 AM, Timothy Arceri wrote: > > > On 16/03/18 19:34, Samuel Pitoiset wrote: >> >> >> On 03/16/2018 09:15 AM, Timothy Arceri wrote: >>> On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? >>> >>> I didn't bother posting them because they are misleading. There are a >>> f

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Samuel Pitoiset
On 03/16/2018 09:58 AM, Timothy Arceri wrote: On 16/03/18 19:34, Samuel Pitoiset wrote: On 03/16/2018 09:15 AM, Timothy Arceri wrote: On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? I didn't bother posting them because they are misleading. There are a few instructions remove h

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Timothy Arceri
On 16/03/18 19:34, Samuel Pitoiset wrote: On 03/16/2018 09:15 AM, Timothy Arceri wrote: On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? I didn't bother posting them because they are misleading. There are a few instructions remove here and there but the main changes are due to lo

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Samuel Pitoiset
On 03/16/2018 09:15 AM, Timothy Arceri wrote: On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? I didn't bother posting them because they are misleading. There are a few instructions remove here and there but the main changes are due to loop unrolling. Totals from affected shaders:

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Timothy Arceri
On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? I didn't bother posting them because they are misleading. There are a few instructions remove here and there but the main changes are due to loop unrolling. Totals from affected shaders: SGPRS: 640 -> 664 (3.75 %) VGPRS: 352 -> 368 (4.

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Samuel Pitoiset
shader stats? On 03/16/2018 06:48 AM, Timothy Arceri wrote: These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --- src/compiler/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compi

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Timothy Arceri
On 16/03/18 17:24, Jason Ekstrand wrote: Assuming the thing I typed in my phone actually works, r-b. :-). I'm a bit surprised we didn't already have that one. It seems so obvious in hindsight. Yeah it worked :) and picked up one more combo I missed. The previous patch only impacted Tomb Raide

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-15 Thread Jason Ekstrand
Assuming the thing I typed in my phone actually works, r-b. :-). I'm a bit surprised we didn't already have that one. It seems so obvious in hindsight. On March 15, 2018 22:48:24 Timothy Arceri wrote: These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --

[Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-15 Thread Timothy Arceri
These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --- src/compiler/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index c9575e6be4..2148bc121b 100644