Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-12 Thread Jason Ekstrand
On November 12, 2018 08:25:50 "Manolova, Plamena" wrote: Hi Jason, Thank you so much for reviewing! In my initial series for ARB_compute_variable_group_size (https://patchwork.freedesktop.org/patch/228130) from which this is extracted, I moved lowering these variables to brw_nir_lower_cs_intri

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-12 Thread Manolova, Plamena
Hi Jason, Thank you so much for reviewing! In my initial series for ARB_compute_variable_group_size (https://patchwork.freedesktop.org/patch/228130) from which this is extracted, I moved lowering these variables to brw_nir_lower_cs_intrinsics and did what you're suggesting i.e. I used the load_loca

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Jason Ekstrand
On Sun, Nov 11, 2018 at 8:46 PM Karol Herbst wrote: > an) > On Mon, Nov 12, 2018 at 12:37 AM Jason Ekstrand > wrote: > > > > On November 11, 2018 16:36:16 Karol Herbst wrote: > > > > > On Sun, Nov 11, 2018 at 10:48 PM Jason Ekstrand > wrote: > > >> > > >> On Sun, Nov 11, 2018 at 3:35 PM Plame

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Karol Herbst
an) On Mon, Nov 12, 2018 at 12:37 AM Jason Ekstrand wrote: > > On November 11, 2018 16:36:16 Karol Herbst wrote: > > > On Sun, Nov 11, 2018 at 10:48 PM Jason Ekstrand > > wrote: > >> > >> On Sun, Nov 11, 2018 at 3:35 PM Plamena Manolova > >> wrote: > >>> > >>> > >>> Lowering shader variables

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Jason Ekstrand
On November 11, 2018 16:36:16 Karol Herbst wrote: On Sun, Nov 11, 2018 at 10:48 PM Jason Ekstrand wrote: On Sun, Nov 11, 2018 at 3:35 PM Plamena Manolova wrote: Lowering shader variables which depend on the local work group size being available in nir_lower_system_values is only possibl

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Karol Herbst
On Sun, Nov 11, 2018 at 10:48 PM Jason Ekstrand wrote: > > On Sun, Nov 11, 2018 at 3:35 PM Plamena Manolova > wrote: >> >> Lowering shader variables which depend on the local work group >> size being available in nir_lower_system_values is only possible >> if the local work group size isn't vari

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Jason Ekstrand
On Sun, Nov 11, 2018 at 3:35 PM Plamena Manolova < plamena.n.manol...@gmail.com> wrote: > Lowering shader variables which depend on the local work group > size being available in nir_lower_system_values is only possible > if the local work group size isn't variable, otherwise this should > be hand

[Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Plamena Manolova
Lowering shader variables which depend on the local work group size being available in nir_lower_system_values is only possible if the local work group size isn't variable, otherwise this should be handled by the native driver (if it supports ARB_compute_variable_group_size). Signed-off-by: Plamen