Re: [Mesa-dev] [PATCH v2] mesa: don't enable online compression for ASTC formats

2015-08-11 Thread Matt Turner
On Tue, Aug 11, 2015 at 4:14 PM, Nanley Chery wrote: > +static bool > +_mesa_format_no_online_compression(const struct gl_context *ctx, GLenum > format) > +{ > + return _mesa_is_astc_format(format) || > + compressedteximage_only_format(ctx, format); Needs one more space of indentation.

[Mesa-dev] [PATCH v2] mesa: don't enable online compression for ASTC formats

2015-08-11 Thread Nanley Chery
From: Nanley Chery In agreement with the ASTC spec, this makes calls to TexImage*D unsuccessful. Implied by the spec, Generate[Texture]Mipmap and [Copy]TexSubImage*D calls must be unsuccessful as well. v2. actually force attempts to compress online to fail. Signed-off-by: Nanley Chery --- src