Re: [Mesa-dev] [PATCH v2] i965: Add script to gen code for OA counter queries

2017-03-02 Thread Emil Velikov
Hi Rob, Pardon there, I've missed a couple of bits/wasn't clear enough: On 1 March 2017 at 17:49, Robert Bragg wrote: > +BUILT_SOURCES += \ > + brw_oa_hsw.h \ > + brw_oa_hsw.c > + By bad here - forgot to mention: Please add these two to a i965_OA_GENERATED_FILES (or similar) variab

Re: [Mesa-dev] [PATCH v2] i965: Add script to gen code for OA counter queries

2017-03-01 Thread Dylan Baker
Thanks! Reviewed-by: Dylan Baker Quoting Robert Bragg (2017-03-01 09:49:16) > Updated based on feedback from Emil, Dylan and Matt. > Adds R/b from Lionel > > Thanks > > --- >8 --- (git am --scissors) > > Avoiding lots of error prone boilerplate and easing our ability to add + > maintain suppo

[Mesa-dev] [PATCH v2] i965: Add script to gen code for OA counter queries

2017-03-01 Thread Robert Bragg
Updated based on feedback from Emil, Dylan and Matt. Adds R/b from Lionel Thanks --- >8 --- (git am --scissors) Avoiding lots of error prone boilerplate and easing our ability to add + maintain support for multiple OA performance counter queries for each generation: This adds a python script to