Re: [Mesa-dev] [PATCH v2] glsl: fix derived cs variables

2017-10-23 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/22/2017 11:37 PM, Ilia Mirkin wrote: There are two issues with the current implementation. First, it relies on the layout(local_size_*) happening in the same shader as the main function, and secondly it doesn't work for variable group sizes. In both cases, th

Re: [Mesa-dev] [PATCH v2] glsl: fix derived cs variables

2017-10-22 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-10-22 14:37:03, Ilia Mirkin wrote: > There are two issues with the current implementation. First, it relies > on the layout(local_size_*) happening in the same shader as the main > function, and secondly it doesn't work for variable group sizes. > > In both cas

[Mesa-dev] [PATCH v2] glsl: fix derived cs variables

2017-10-22 Thread Ilia Mirkin
There are two issues with the current implementation. First, it relies on the layout(local_size_*) happening in the same shader as the main function, and secondly it doesn't work for variable group sizes. In both cases, the simplest fix is to move the setup of these derived values to a later time,