Re: [Mesa-dev] [PATCH v2] glsl: fix array assignments of a swizzled vector

2018-10-05 Thread Ilia Mirkin
On Sat, Oct 6, 2018 at 1:24 AM Ilia Mirkin wrote: > > This happens in situations where we might do > > vec.wzyx[i] = ... > > The swizzle would get effectively ignored because of the interaction > between how ir_assignment->set_lhs works and overwriting the write_mask. > There are two cases, one

[Mesa-dev] [PATCH v2] glsl: fix array assignments of a swizzled vector

2018-10-05 Thread Ilia Mirkin
This happens in situations where we might do vec.wzyx[i] = ... The swizzle would get effectively ignored because of the interaction between how ir_assignment->set_lhs works and overwriting the write_mask. There are two cases, one where i is a constant, and another where i is variable. We have t