Re: [Mesa-dev] [PATCH v2] glsl: disallow implicit conversions in ESSL shaders

2016-01-27 Thread Kenneth Graunke
On Wednesday, January 27, 2016 5:18:29 PM PST Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > OK, ran piglit on all of this and noticed the issue with state == NULL in > can_implicitly_convert_to. With that fixed, the only piglit regression is > > spec/arb_blend_func_extended/arb_blend

Re: [Mesa-dev] [PATCH v2] glsl: disallow implicit conversions in ESSL shaders

2016-01-27 Thread Timothy Arceri
On Wed, 2016-01-27 at 17:18 -0500, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin Surprising the CTS or deqp hasn't flushed this out already. I ran this through Intels CI system and the only change in test results was the bad piglit test. Looks corrent to me. Reviewed-by: Timothy Arceri > --

[Mesa-dev] [PATCH v2] glsl: disallow implicit conversions in ESSL shaders

2016-01-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- OK, ran piglit on all of this and noticed the issue with state == NULL in can_implicitly_convert_to. With that fixed, the only piglit regression is spec/arb_blend_func_extended/arb_blend_func_extended-fbo-extended-blend-pattern_gles3: pass fail Which is precisely