Re: [Mesa-dev] [PATCH v2] glsl: add double support for packing varyings

2015-02-23 Thread Ilia Mirkin
On Mon, Feb 23, 2015 at 4:27 PM, Ian Romanick wrote: > On 02/20/2015 10:56 AM, Ilia Mirkin wrote: >> Doubles are always packed, but a single double will never cross a slot >> boundary -- single slots can still be wasted in some situations. >> >> Signed-off-by: Ilia Mirkin >> --- >> >> Packing *al

Re: [Mesa-dev] [PATCH v2] glsl: add double support for packing varyings

2015-02-22 Thread Dave Airlie
On 21 February 2015 at 04:56, Ilia Mirkin wrote: > Doubles are always packed, but a single double will never cross a slot > boundary -- single slots can still be wasted in some situations. I can't say I'm going to know if this is designed right, but the patch looks good to me and it seems like th

[Mesa-dev] [PATCH v2] glsl: add double support for packing varyings

2015-02-20 Thread Ilia Mirkin
Doubles are always packed, but a single double will never cross a slot boundary -- single slots can still be wasted in some situations. Signed-off-by: Ilia Mirkin --- Packing *all* doubles is a bit of a hack... we shouldn't need to do it for dvec2/dvec4. And yet, here we are. This means that set