Re: [Mesa-dev] [PATCH v2] glcpp: error on multiple #else/#elif directives

2014-01-02 Thread Carl Worth
Erik Faye-Lund writes: > Here's a resend of an older patch (original > <1379968503-30246-1-git-send-email-kusmab...@gmail.com>), this time > with a better commit message, and a similar treatment for > elif-after-else. Thanks for the commit, Erik. I've just pushed this out with the previous Revie

Re: [Mesa-dev] [PATCH v2] glcpp: error on multiple #else/#elif directives

2013-12-20 Thread Kenneth Graunke
On 12/17/2013 07:37 AM, Erik Faye-Lund wrote: > The preprocessor currently accepts multiple else/elif-groups > per if-section. The GLSL-preprocessor is defined by the C++ > specification, which defines the following parse-rule: > > if-section: > if-group elif-groups(opt) else-group(opt) endi

Re: [Mesa-dev] [PATCH v2] glcpp: error on multiple #else/#elif directives

2013-12-20 Thread Ian Romanick
On 12/17/2013 07:37 AM, Erik Faye-Lund wrote: > The preprocessor currently accepts multiple else/elif-groups > per if-section. The GLSL-preprocessor is defined by the C++ > specification, which defines the following parse-rule: > > if-section: > if-group elif-groups(opt) else-group(opt) endi

[Mesa-dev] [PATCH v2] glcpp: error on multiple #else/#elif directives

2013-12-17 Thread Erik Faye-Lund
The preprocessor currently accepts multiple else/elif-groups per if-section. The GLSL-preprocessor is defined by the C++ specification, which defines the following parse-rule: if-section: if-group elif-groups(opt) else-group(opt) endif-line This clearly only allows a single else-group, th