Re: [Mesa-dev] [PATCH v1] mesa: Avoid read of uninitialized variable

2017-03-01 Thread Anuj Phogat
On Wed, Mar 1, 2017 at 2:34 PM, Robert Foss wrote: > The is_color_attachement variable is later read when handling two > separate error cases, where only one of the cases results in the > variable being initialized. > > This can be avoided by giving the variable a safe default value. > > Coverity-

Re: [Mesa-dev] [PATCH v1] mesa: Avoid read of uninitialized variable

2017-03-01 Thread Ilia Mirkin
Sure, why not. In practice, this can never hit, but the cost of making Coverity slightly happier is low. (Hm, or can it hit, with a surfaceless context...) Reviewed-by: Ilia Mirkin On Wed, Mar 1, 2017 at 5:34 PM, Robert Foss wrote: > The is_color_attachement variable is later read when handling

[Mesa-dev] [PATCH v1] mesa: Avoid read of uninitialized variable

2017-03-01 Thread Robert Foss
The is_color_attachement variable is later read when handling two separate error cases, where only one of the cases results in the variable being initialized. This can be avoided by giving the variable a safe default value. Coverity-Id: 1398631 Signed-off-by: Robert Foss --- src/mesa/main/fbobj