Re: [Mesa-dev] [PATCH shader-db 4/5] nv-report: make use of argparse

2018-08-03 Thread Ilia Mirkin
Oh. argparse.add_argument doesn't do what I thought it did. Neat. I was going by memory, which most resembles a colander by now =/ This change is Reviewed-by: Ilia Mirkin On Fri, Aug 3, 2018 at 5:34 PM, Rhys Perry wrote: > They should still be positional arguments. > > For example, the output

Re: [Mesa-dev] [PATCH shader-db 4/5] nv-report: make use of argparse

2018-08-03 Thread Rhys Perry
They should still be positional arguments. For example, the output of --help (after the 5th patch) is: > usage: nv-report.py [-h] [--top ATTR N] [--smallest ATTR N] before after > > Shows changes between two shader-db runs for the nouveau drivers. > > positional arguments: > before

Re: [Mesa-dev] [PATCH shader-db 4/5] nv-report: make use of argparse

2018-08-03 Thread Ilia Mirkin
I'd rather keep these as positional args. You can still use argparse for other optional items. On Fri, Aug 3, 2018 at 3:53 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > nv-report.py | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/nv-report.py

[Mesa-dev] [PATCH shader-db 4/5] nv-report: make use of argparse

2018-08-03 Thread Rhys Perry
Signed-off-by: Rhys Perry --- nv-report.py | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/nv-report.py b/nv-report.py index 079b2e08a3..1c1491af0a 100644 --- a/nv-report.py +++ b/nv-report.py @@ -12,11 +12,15 @@ fields, except for the type, are optional. imp