Re: [Mesa-dev] [PATCH shader-db 2/3] run: introduce get_glsl_version() helper

2017-08-21 Thread Eric Engestrom
On Monday, 2017-08-21 18:09:01 +0100, Emil Velikov wrote: > On 21 August 2017 at 14:33, Eric Engestrom wrote: > > On Monday, 2017-08-21 11:27:20 +0100, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> Flesh the duplicated functionality to a helper. > >> Use const char * + sscanf to keep the

Re: [Mesa-dev] [PATCH shader-db 2/3] run: introduce get_glsl_version() helper

2017-08-21 Thread Emil Velikov
On 21 August 2017 at 14:33, Eric Engestrom wrote: > On Monday, 2017-08-21 11:27:20 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Flesh the duplicated functionality to a helper. >> Use const char * + sscanf to keep the compiler happy. > > Can you explain why you replaced strtol() with ssc

Re: [Mesa-dev] [PATCH shader-db 2/3] run: introduce get_glsl_version() helper

2017-08-21 Thread Eric Engestrom
On Monday, 2017-08-21 11:27:20 +0100, Emil Velikov wrote: > From: Emil Velikov > > Flesh the duplicated functionality to a helper. > Use const char * + sscanf to keep the compiler happy. Can you explain why you replaced strtol() with sscanf() in the commit message? Reviewed-by: Eric Engestrom

[Mesa-dev] [PATCH shader-db 2/3] run: introduce get_glsl_version() helper

2017-08-21 Thread Emil Velikov
From: Emil Velikov Flesh the duplicated functionality to a helper. Use const char * + sscanf to keep the compiler happy. Signed-off-by: Emil Velikov --- A bit more could be fleshed out into helper(s). This is enough to keep the compiler happy w/o being too invasive. --- run.c | 20